[SM6.10] LinAlg Validation: Disallow undef as builtin params#8588
Open
V-FEXrt wants to merge 1 commit into
Open
[SM6.10] LinAlg Validation: Disallow undef as builtin params#8588V-FEXrt wants to merge 1 commit into
V-FEXrt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a validation rule to disallow
undefas a parameter to Linalg builtins and updates all the broken tests.The tests are fixed by using the fillmatrix builtin to have an actual matrix SSA value. This will be invalid in some of the cases but those invalid uses will be much easier to fix as they are found/disallowed by future validation PRs